CFE-4442: Clarified need to specify namespace when defining custom policy update bundle #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@craigcomstock could you take this for a spin? Also, the Warning message that I added, it's currently classed to |
craigcomstock
requested changes
Oct 8, 2024
cfe_internal/update/update_policy.cf
Outdated
| "User specified update bundle: $(def.mpf_update_policy_bundle)" | ||
| if => "have_user_specified_update_bundle"; | ||
|
|
||
| "WARNING User specified update bundle '$(def.mpf_update_policy_bundle)' does not specify a namespace. Please specify a namespace, e.g. 'default:$(def.mpf_update_policy_bundle)'." |
There was a problem hiding this comment.
Yes, I think this should be moved outside of the current guards and made to report at any running log level, e.g. any::
nickanderson
force-pushed
the
CFE-4442/master
branch
from
9038593
to
9a2fc63
Compare
…olicy update bundle Ticket: CFE-4442 Changelog: None
nickanderson
force-pushed
the
CFE-4442/master
branch
from
9a2fc63
to
07fac61
Compare
craigcomstock
approved these changes
Oct 9, 2024
nickanderson
added
the
cherry-pick?
|
Yes, this should be picked to 3.24.x and 3.21.x. I have yet to do it. |
nickanderson
removed
the
cherry-pick?
|
backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change clarifies the need to specify the namespace when defining a custom policy update bundle both in documentation in reports emitted by policy.
If namespace is not specified the bundle will not be found and will be unable to run.