ENT-10656: Added missing build steps to repository module to align with CFEngine Build index #2732
Conversation
|
@olehermanse I am not sure what to set It influences not only the version string for the policy itself ( |
|
@nickanderson IMO, it would be wrong to set an exact version here explicitly, when you are between versions your version number should reflect this. If we want the self upgrade policy to handle this better, that's what needs to be fixed, I think. |
… Build index Now if you cfbs add https://github.com/cfengine/masterfiles you will get the same build steps as those used when you cfbs add masterfiles from the CFEngine Build index. Note: EXPLICIT_VERSION and EXPLICIT_RELEASE are not set here, this not only affects the version of the policy, but also the default binary version to target during self upgrade. Ticket: ENT-10656 Changelog: Title Co-authored-by: Ole Herman Schumacher Elgesem <[email protected]>
nickanderson
force-pushed
the
ENT-10656/master
branch
from
cb30c9a
to
b89489c
Compare
nickanderson
changed the title
| "steps": ["run ./prepare.sh -y", | ||
| "delete cfe_internal/core/watchdog/README.md", | ||
| "delete cfe_internal/enterprise/ha/ha_info.json", | ||
| "delete .github", | ||
| "delete inventory/README.md", | ||
| "delete lib/README.md", | ||
| "delete LICENSE", | ||
| "delete modules/promises", | ||
| "delete .no-distrib", | ||
| "delete services/autorun/README.md", | ||
| "delete templates/README.md", | ||
| "copy ./ ./"] |
There was a problem hiding this comment.
@nickanderson actually, this is not needed. The current (newest) version of prepare.sh has all of these deletes inside of it.
See:
Lines 61 to 100 in 998f71d
This matches the latest version in the index (3.22 non LTS, which is not the default, since we default to latest LTS):
So I guess the latest improvements to the prepare.sh script have not been backported to 3.21.x. Feel free to do this, to prepare mpf for the upcoming 3.21 release, if you'd like.
There was a problem hiding this comment.
Looks like that backporting has also been done already: #2643
Now if you cfbs add https://github.com/cfengine/masterfiles you will get the
same build steps as those used when you cfbs add masterfiles from the CFEngine
Build index.
Ticket: ENT-10656
Changelog: Title