-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise section 4, include new subsection on leap seconds, define utc
and tai
calendars and leap_seconds
in units_metadata
#541
base: main
Are you sure you want to change the base?
Conversation
utc
and tai
calendars and leap_seconds
in units_metadata
utc
and tai
calendars and leap_seconds
in units_metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions -- none of the show-stoppers -- do with them what you will :-)
I commente din one place, but everywhere, I"d prefer:
"datetime" or "date-time" over "date/time"
But if this has already been thoroughly hashed out -- no big deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks!
@davidhassell @JonathanGregory You might want to consider removing the word |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is outstanding! Thanks for all the hard work -- quite a slog, but the CF community will greatly benefit.
Update GH-PAGES deployment
See issue #542 for discussion of these changes.
Release checklist
cf-conventions.adoc
? Add in two places: on line 3 and under.Additional Authors
inAbout the authors
.cf-conventions.adoc
up to date? Versioning inspired by SemVer.history.adoc
up to date?