Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise section 4, include new subsection on leap seconds, define utc and tai calendars and leap_seconds in units_metadata #541

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

Revise section 4, include new subsection on leap seconds, define utc and tai calendars and leap_seconds in units_metadata #541

wants to merge 38 commits into from

Conversation

JonathanGregory
Copy link
Contributor

@JonathanGregory JonathanGregory commented Sep 15, 2024 •
edited
Loading

See issue #542 for discussion of these changes.

Release checklist

  • [NA] Authors updated in cf-conventions.adoc? Add in two places: on line 3 and under .Additional Authors in About the authors.
  • [NA] Next version in cf-conventions.adoc up to date? Versioning inspired by SemVer.
  • [Y] history.adoc up to date?
  • [Y] Conformance document up to date?

@JonathanGregory JonathanGregory mentioned this pull request Sep 16, 2024
Open
@JonathanGregory JonathanGregory changed the title *DO NOT MERGE* Revise section 4, include new subsection on leap seconds, define utc and tai calendars and leap_seconds in units_metadata Revise section 4, include new subsection on leap seconds, define utc and tai calendars and leap_seconds in units_metadata Sep 16, 2024
@JonathanGregory JonathanGregory linked an issue Sep 16, 2024 that may be closed by this pull request
Clarification of time coordinates, especially leap seconds, define utc and tai calendars and leap_seconds in units_metadata #542
Open
@JonathanGregory JonathanGregory added this to the 1.12 milestone Sep 16, 2024
ChrisBarker-NOAA
ChrisBarker-NOAA approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@ChrisBarker-NOAA ChrisBarker-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions -- none of the show-stoppers -- do with them what you will :-)

I commente din one place, but everywhere, I"d prefer:

"datetime" or "date-time" over "date/time"

But if this has already been thoroughly hashed out -- no big deal.

ch01.adoc Outdated Show resolved Hide resolved
ch03.adoc Show resolved Hide resolved
ch04.adoc Show resolved Hide resolved
ch04.adoc Outdated Show resolved Hide resolved
ch04.adoc Outdated Show resolved Hide resolved
ch04.adoc Outdated Show resolved Hide resolved
ch04.adoc Outdated Show resolved Hide resolved
ch04.adoc Outdated Show resolved Hide resolved
ChrisBarker-NOAA
ChrisBarker-NOAA approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@ChrisBarker-NOAA ChrisBarker-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@chris-little
Copy link

@davidhassell @JonathanGregory You might want to consider removing the word midnight, or replace it with midnight at 0 degrees longitude. It is a bit UK-centric. The ISO 8601 standard removed that word from its content some years ago.
Otherwise, a good clear exposition of the topics.

ChrisBarker-NOAA
ChrisBarker-NOAA approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@ChrisBarker-NOAA ChrisBarker-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is outstanding! Thanks for all the hard work -- quite a slog, but the CF community will greatly benefit.

ch04.adoc Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisBarker-NOAA ChrisBarker-NOAA ChrisBarker-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12
4 participants
@JonathanGregory @chris-little @ChrisBarker-NOAA @cofinoa