Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efisher008 post workshop updates #2 #558

Merged
merged 11 commits into from
Nov 21, 2024
Merged

Conversation

efisher008
Copy link
Contributor

No description provided.

@erget
Copy link
Member

erget commented Nov 20, 2024

Hi Ellie, before we merge this could you change the width and height to be % rather than pixels? Otherwise we'll have issues with the pictures looking really different on different devices.

@@ -18,8 +18,8 @@ During Part I, speakers were invited from a broad range of CF users and potentia
The aim of the workshop was to maximise the usefulness of CF to a wide range of communities, encourage others to join and contribute to the CF community effort, and enhance interoperability with other widely used standards.
The desired outcome following the workshop will be a publication of the proceedings, including a roadmap for development of the CF conventions and vocabularies over the next 1 to 5 years.

![Group photo outside SMHI](../Data/media/images/CF2024_group2.JPG)
![Group photo outside dinner venue](../Data/media/images/CF2024_group1.JPG)
<img src=../Data/media/images/CF2024_group2.JPG alt="Group photo outside SMHI" width="600" height="400">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that Daniel made a comment (somewhere?) that the resizing preferably should be in % rather than in pixels. Can this be done while keeping the aspect ratio? ping @erget

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, something like

<img src="foo.jpg" width="20%" height="auto">

will try it out...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larsbarring how about that, check the rendered file now and merge if you're happy :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erget @larsbarring apologies that I wasn't able to make this change yesterday, thanks Daniel for adding in the responsive sizing. Lars also wanted a missing lightning talk added in so I've just made that change.

erget and others added 2 commits November 21, 2024 10:24
Use responsive sizing on images
Adding Ethan's Zarr/GeoZarr lightning talk to the agenda.
@erget erget merged commit 8a964d5 into main Nov 21, 2024
1 check passed
@efisher008
Copy link
Contributor Author

Hi, I've noticed the two group photos aren't rendering properly - maybe some small formatting issue? The HTML is currently exposed on the workshop page. Perhaps @erget you'd be able to take a look at this when you get the chance?

@erget
Copy link
Member

erget commented Nov 25, 2024

Interesting... The way it loads in test always looks good but I think when Jeckyll compiles it kills the resizing. In the end I resized the images themselves! The originals are still in the repo, you'dj ust have to rewind them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants