-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug: Tag debug shapes #593
base: master
Are you sure you want to change the base?
Conversation
This is would also resolve #463 if you used the |
They are different. Marks must be considered for bbox calculation and intersection (?), debug shapes not. Although, this is not yet implemented in this PR. |
I don't think marks should be considered for intersections and would they be big enough to really count towards a bounding box? Besides that, if we do have separate keys for debug, marks, hidden and ignore, would there be a way to combine them into one field? Maybe a "type" or "class" key that holds "debug" or "mark", it could even be an array to hold multiple if needed. It could even be a bytefield... |
Yes, I think some kind of "class" is good. We could then provide a function for filtering out certain elements. |
If we are still aiming for modifiers in 0.3.0, can this be blocked until modifiers are implemented? Then we can use whatever system works for modifiers. |
Yes. Although path-replacing modifiers need no special handling, as they just replace the original path. |
Tag debug paths as such and skip them in
merge-path
.Debug shapes bring other problems, maybe we should remove the feature or remove documentation about it.
Fixes #575