Skip to content

Commit

Permalink
Fix CI after uncontrollable dev-dependency update.
Browse files Browse the repository at this point in the history
Criterion has a transitive dependency that we can't control the version
of, which requires > Rust 1.65.  This means we can no longer run tests
using that version, even though it's our MSRV.  So switch to just
building with our MSRV rather than building *and* testing.  In practice
this should be fine, as building should be enough since we're running
tests with latest stable anyway.
  • Loading branch information
cessen committed Oct 31, 2024
1 parent e1299e9 commit 524a580
Showing 1 changed file with 20 additions and 2 deletions.
22 changes: 20 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ jobs:
matrix:
toolchain:
- stable
- "1.65"
runs-on: ubuntu-latest
steps:
# Get a checkout and rust toolchain.
Expand All @@ -27,7 +26,26 @@ jobs:
toolchain: ${{matrix.toolchain}}
override: true

# Build and test
# Build and test.
- run: cargo +${{matrix.toolchain}} build
- run: cargo +${{matrix.toolchain}} test
- run: cargo +${{matrix.toolchain}} bench --no-run

build:
name: Build, MSRV
strategy:
matrix:
toolchain:
- "1.65"
runs-on: ubuntu-latest
steps:
# Get a checkout and rust toolchain.
- uses: actions/checkout@v2
- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: ${{matrix.toolchain}}
override: true

# Build.
- run: cargo +${{matrix.toolchain}} build

0 comments on commit 524a580

Please sign in to comment.