fix gather/scatter type verification #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computes and Fixes are allways doubles. This is just a small fixup - I think In the future we should use
LAMMPS_INT
LAMMPS_INT_2D
LAMMPS_DOUBLE
LAMMPS_DOUBLE_2D
for the type parameter instead of
Int32
andFloat64
. This makes the API more consistent and we're able to return Vectors instead of 1xN Matrices while preserving type stability.