Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gather/scatter type verification #57

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

Joroks
Copy link
Collaborator

@Joroks Joroks commented Jul 8, 2024

Computes and Fixes are allways doubles. This is just a small fixup - I think In the future we should use

  • LAMMPS_INT
  • LAMMPS_INT_2D
  • LAMMPS_DOUBLE
  • LAMMPS_DOUBLE_2D

for the type parameter instead of Int32 and Float64. This makes the API more consistent and we're able to return Vectors instead of 1xN Matrices while preserving type stability.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.91%. Comparing base (913e7c3) to head (180f973).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #57       +/-   ##
===========================================
+ Coverage   54.56%   67.91%   +13.34%     
===========================================
  Files           2        2               
  Lines         449      427       -22     
===========================================
+ Hits          245      290       +45     
+ Misses        204      137       -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Joroks Joroks merged commit ae5ada0 into cesmix-mit:main Jul 9, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants