Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy kwarg to extract_atom #37

Closed
wants to merge 1 commit into from
Closed

Add copy kwarg to extract_atom #37

wants to merge 1 commit into from

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Nov 4, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2023

Codecov Report

Merging #37 (c03b066) into main (e67bbc4) will increase coverage by 0.24%.
The diff coverage is 75.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   36.00%   36.24%   +0.24%     
==========================================
  Files           2        2              
  Lines         375      378       +3     
==========================================
+ Hits          135      137       +2     
- Misses        240      241       +1     
Files Coverage Δ
src/LAMMPS.jl 53.96% <75.00%> (+0.19%) ⬆️

@vchuravy vchuravy requested a review from swyant November 4, 2023 20:11
@vchuravy
Copy link
Member Author

vchuravy commented Nov 4, 2023

@swyant I had this code laying around. Not sure why though xD

@vchuravy
Copy link
Member Author

With #43 we could close this and tell the user to use gather instead.

@vchuravy vchuravy mentioned this pull request Jun 22, 2024
@swyant
Copy link
Member

swyant commented Jun 25, 2024

Yea I think that's fine, on the assumption that the user can still use extract_atom if they want to access the memory in-place, right?

@vchuravy vchuravy closed this Jun 25, 2024
@vchuravy vchuravy deleted the vc/copy branch June 25, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants