fix: analysis total time overstated #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collect the stacks and only sum the unique entries e.g If we have an analysis like this methodA: 5s methodB: 3s methodC: 2s Sibling Methods The three methods are at the same level directly called from EXECUTION_STARTED. All 3 should be summed as they are in different stacks. Total: 10s Child Methods methodB is a child of methodA and methodC is a sibling of methodA. we first add methodA to the total but the total for methodB has already been accounted by including methodA so we skip it and any other children of methodA. methodC is in a unique stack and needs to be added to the total. Total: 7s
lcottercertinia
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
analysis total time sum unique stacks
Collect the stacks and only sum the unique entries e.g
If we have an analysis like this
methodA: 5s
methodB: 3s
methodC: 2s
Sibling Methods
The three methods are at the same level directly called from EXECUTION_STARTED.
All 3 should be summed as they are in different stacks.
Total: 10s
Child Methods
methodB is a child of methodA and methodC is a sibling of methodA.
we first add methodA to the total but the total for methodB has already been accounted by including methodA so we skip it and any other children of methodA.
methodC is in a unique stack and needs to be added to the total.
Total: 7s
Type of change (check all applicable)
[optional] Any images / gifs / video
Related Tickets & Documents
Related Issue #
fixes #526
resolves #
closes #
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?