Merge pull request #546 from lukecotter/perf-calltree-getalltypes

certinia · Dec 14, 2024 · a5cde71 · a5cde71
2 parents d31f3cd + 4892d01
commit a5cde71
Showing 1 changed file with 20 additions and 3 deletions.
diff --git a/log-viewer/modules/components/calltree-view/CalltreeView.ts b/log-viewer/modules/components/calltree-view/CalltreeView.ts
@@ -210,10 +210,27 @@ export class CalltreeView extends LitElement {
   _findEvt = ((event: FindEvt) => this._find(event)) as EventListener;
 
   _getAllTypes(data: LogLine[]): string[] {
-    const flatten = (line: LogLine): LogLine[] => [line, ...line.children.flatMap(flatten)];
-    const flattened = data.flatMap(flatten);
+    const flattened = this._flatten(data);
+    const types = new Set<string>();
+    for (const line of flattened) {
+      types.add(line.type?.toString() ?? '');
+    }
+    return Array.from(types).sort();
+  }
+
+  _flat(arr: LogLine[], target: LogLine[]) {
+    arr.forEach((el) => {
+      target.push(el);
+      if (el.children.length > 0) {
+        this._flat(el.children, target);
+      }
+    });
+  }
 
-    return [...new Set(flattened.map((item) => item.type?.toString() ?? ''))].sort();
+  _flatten(arr: LogLine[]) {
+    const flattened: LogLine[] = [];
+    this._flat(arr, flattened);
+    return flattened;
   }
 
   _handleShowDetailsChange(event: Event) {