Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command-issuer to external issuers list #1303

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Add command-issuer to external issuers list #1303

merged 2 commits into from
Oct 13, 2023

Conversation

m8rmclaren
Copy link
Contributor

Hey hey! Adding external issuer listing for the Keyfactor Command External Issuer for cert-manager. Let me know if any additional changes need to be made.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 21, 2023
@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 3227f45
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/650cad7505a9da0007fa1f46
😎 Deploy Preview https://deploy-preview-1303--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thx for sharing!

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@jetstack-bot jetstack-bot merged commit 7ebe1e1 into cert-manager:master Oct 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants