RELEASE BLOCKER: Add special case handling of cert with negative serial number #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also slack.
Go 1.23 changes ParseCertificate to no longer accept negative serial numbers (in line with specs).
This breaks the trust package we provide which contains an older CA with a negative serial number in it.
As a special case for just this one cert, we handle the error and skip including the cert rather than failing the entire bundle because of this cert.
This also adds tests for the behavior of the new
compat.ParseCertificate
function, both with the GODEBUG workaround set and unset.Users who need to trust this CA will for the foreseeable future still be able to include it by setting the
GODEBUG
environment variable when running trust-manager.