Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RELEASE BLOCKER: Add special case handling of cert with negative serial number #515

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SgtCoDFish
Copy link
Member

See also slack.

Go 1.23 changes ParseCertificate to no longer accept negative serial numbers (in line with specs).

This breaks the trust package we provide which contains an older CA with a negative serial number in it.

As a special case for just this one cert, we handle the error and skip including the cert rather than failing the entire bundle because of this cert.

This also adds tests for the behavior of the new compat.ParseCertificate function, both with the GODEBUG workaround set and unset.

Users who need to trust this CA will for the foreseeable future still be able to include it by setting the GODEBUG environment variable when running trust-manager.

@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Dec 16, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sgtcodfish. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 16, 2024
@SgtCoDFish SgtCoDFish force-pushed the negative-serial-special-case branch 2 times, most recently from b8a6b25 to 74e21c7 Compare December 17, 2024 09:37
@SgtCoDFish SgtCoDFish force-pushed the negative-serial-special-case branch from 74e21c7 to fc17604 Compare December 17, 2024 09:41
@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented Dec 17, 2024

@SgtCoDFish: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-trust-manager-smoke fc17604 link true /test pull-trust-manager-smoke

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant