-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option for deployment annotations to helm chart #424
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: a-hat <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @a-hat. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@erikgb could you kindly take a look? |
/ok-to-test |
@a-hat This new feature seems ok to merge when it passes CI. 😄 |
@a-hat: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Issues go stale after 90d of inactivity. |
Hi!
This PR adds the option to add annotations to the trust-manager deployment. In our specific use case we need it to apply custom annotations to exclude the deployment from kyverno policy validation.
The cert-manager chart allows the same configuration option, but for trust-manager it is missing.
I have seen that #214 contains the same change, but from what I understand only the certificate annotations are under discussion, so I hope my PR can get merged :)