Add namespace value for configuring the destination namespace (Helm subchart) #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-manager-prow
bot
added
dco-signoff: no
…kubernetes manifests Signed-off-by: jaydee94 <[email protected]>
cert-manager-prow
bot
added
dco-signoff: yes
maelvls
reviewed
May 31, 2024
maelvls
reviewed
May 31, 2024
Co-authored-by: Maël Valais <[email protected]> Signed-off-by: Jan <[email protected]>
Signed-off-by: Maël Valais <[email protected]>
|
Thank you for this patch, Jan! With this patch, people using openshift-routes' helm chart as a sub chart will be able to configure the namespace. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
maelvls
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option for configuring the namespace for all resources to be installed into.
If not defined in values file then the helm release namespace is used.
By default this is not set so the helm release namespace will be used.