Implement private key size annotation #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
dco-signoff: no
Signed-off-by: Norwin Schnyder <[email protected]>
snorwin
force-pushed
the
keysize-annotation
branch
from
6762f17 to
7d16bd2
Compare
jetstack-bot
added
dco-signoff: yes
|
@jacksgt would be really appreciated if you could quickly have a look at this PR. |
jetstack-bot
added
the
approved
|
@maelvls if there are no further changes required, would you be able to merge the PR and consider releasing it? |
|
/approve Yes, let's have it released! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you! Very much appreciated 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new feature that allows users to specify the private key size in the
Routeresource, similar to the functionality currently available for theIngressresource. With the increasing shift away from the default RSA key size of2048, which is often no longer supported or used, this addition provides users with the flexibility to define a key size that aligns with their security requirements and best practices.