ensure deterministic cert name + names not too long

Signed-off-by: Ashley Davis <[email protected]>
cert-manager · Oct 2, 2024 · 5b2d427 · 5b2d427
1 parent 88600f5
commit 5b2d427
Show file tree

Hide file tree

Showing 4 changed files with 330 additions and 145 deletions.
diff --git a/internal/controller/sync.go b/internal/controller/sync.go
@@ -477,14 +477,14 @@ func (r *RouteController) buildNextCert(ctx context.Context, route *routev1.Rout
 		revisionHistoryLimit = &typedLimit
 	}
 
-	secretName := route.Name + "-tls-cert"
+	secretName := safeKubernetesNameAppend(route.Name, "tls")
 
 	// Build the Certificate resource with the collected information
 	// https://cert-manager.io/docs/usage/certificate/
 	cert := &cmapi.Certificate{
 		ObjectMeta: metav1.ObjectMeta{
-			GenerateName: route.Name + "-",
-			Namespace:    route.Namespace,
+			Name:      safeKubernetesNameAppend(route.Name, "cert"),
+			Namespace: route.Namespace,
 			OwnerReferences: []metav1.OwnerReference{
 				*metav1.NewControllerRef(
 					route,