apply changes proposed in PR review comments

Signed-off-by: Tim Ramlot <[email protected]>
cert-manager · Jul 8, 2024 · 14cb9e0 · 14cb9e0
1 parent 3477b5d
commit 14cb9e0
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 8 deletions.
diff --git a/deploy/charts/openshift-routes/Chart.yaml b/deploy/charts/openshift-routes/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v2
 
-name: cert-manager-openshift-routes
+name: openshift-routes
 type: application
 description: A Helm chart to deploy openshift-routes adapter for cert-manager on Kubernetes
 

diff --git a/deploy/charts/openshift-routes/README.md b/deploy/charts/openshift-routes/README.md
@@ -44,7 +44,7 @@ repository: jetstack/cert-manager-openshift-routes
 #### **image.repository** ~ `string`
 > Default value:
 > ```yaml
-> quay.io/jetstack/cert-manager-openshift-routes
+> ghcr.io/cert-manager/cert-manager-openshift-routes
 > ```
 
 Target image repository.
@@ -142,7 +142,6 @@ For example:
 ```yaml
 resources:
   limits:
-    cpu: 100m
     memory: 128Mi
   requests:
     cpu: 100m

diff --git a/deploy/charts/openshift-routes/values.schema.json b/deploy/charts/openshift-routes/values.schema.json
@@ -107,7 +107,7 @@
       "type": "string"
     },
     "helm-values.image.repository": {
-      "default": "quay.io/jetstack/cert-manager-openshift-routes",
+      "default": "ghcr.io/cert-manager/cert-manager-openshift-routes",
       "description": "Target image repository.",
       "type": "string"
     },
@@ -215,7 +215,7 @@
     },
     "helm-values.resources": {
       "default": {},
-      "description": "Kubernetes pod resources\nref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/\n\nFor example:\nresources:\n  limits:\n    cpu: 100m\n    memory: 128Mi\n  requests:\n    cpu: 100m\n    memory: 128Mi",
+      "description": "Kubernetes pod resources\nref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/\n\nFor example:\nresources:\n  limits:\n    memory: 128Mi\n  requests:\n    cpu: 100m\n    memory: 128Mi",
       "type": "object"
     },
     "helm-values.securityContext": {

diff --git a/deploy/charts/openshift-routes/values.yaml b/deploy/charts/openshift-routes/values.yaml
@@ -30,7 +30,7 @@ image:
   # registry: quay.io
 
   # Target image repository.
-  repository: quay.io/jetstack/cert-manager-openshift-routes
+  repository: ghcr.io/cert-manager/cert-manager-openshift-routes
 
   # Override the image tag to deploy by setting this variable.
   # If no value is set, the chart's appVersion is used.
@@ -93,7 +93,6 @@ securityContext:
 # For example:
 #  resources:
 #    limits:
-#      cpu: 100m
 #      memory: 128Mi
 #    requests:
 #      cpu: 100m

diff --git a/make/00_mod.mk b/make/00_mod.mk
@@ -31,7 +31,7 @@ deploy_name := openshift-routes
 deploy_namespace := cert-manager
 
 helm_chart_source_dir := deploy/charts/openshift-routes
-helm_chart_name := cert-manager-openshift-routes
+helm_chart_name := openshift-routes
 helm_chart_version := $(VERSION:v%=%)
 helm_labels_template_name := cert-manager-openshift-routes.labels
 helm_docs_use_helm_tool := 1