Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump chart for release #110

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e_tests.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# This workflow runs priviledged e2e tests for trusted sources.
# This workflow runs privileged e2e tests for trusted sources.
name: e2e-tests
on:
push:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr_e2e_tests.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# This workflow runs priviledged e2e tests for untrusted sources (incomming PRs).
# This workflow runs privileged e2e tests for untrusted sources (incomming PRs).
name: pr-e2e-tests
on:
pull_request_target:
Expand Down
4 changes: 2 additions & 2 deletions deploy/charts/google-cas-issuer/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ maintainers:
sources:
- https://github.com/jetstack/google-cas-issuer

appVersion: v0.6.2
version: v0.6.2
appVersion: v0.6.3
version: v0.6.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already a 0.7.0 release, so should this be 0.7.1 or 0.8.0 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... I hadn't actually clocked that all of this is overriden by the release action and hidden away in there 😭

Quite different to our other release processes but I'd expected it to be similar. Maybe I misremembered it!

Never mind, then - this PR is entirely waste. I'll close! Thanks for taking a look!

4 changes: 2 additions & 2 deletions deploy/charts/google-cas-issuer/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# cert-manager-google-cas-issuer

![Version: v0.6.2](https://img.shields.io/badge/Version-v0.6.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.6.2](https://img.shields.io/badge/AppVersion-v0.6.2-informational?style=flat-square)
![Version: v0.6.3](https://img.shields.io/badge/Version-v0.6.3-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.6.3](https://img.shields.io/badge/AppVersion-v0.6.3-informational?style=flat-square)

A Helm chart for jetstack/google-cas-issuer

Expand Down Expand Up @@ -30,7 +30,7 @@ A Helm chart for jetstack/google-cas-issuer
| deploymentAnnotations | object | `{}` | Optional additional annotations to add to the google-cas-issuer Deployment |
| image.pullPolicy | string | `"IfNotPresent"` | Kubernetes imagePullPolicy on Deployment. |
| image.repository | string | `"quay.io/jetstack/cert-manager-google-cas-issuer"` | Target image repository. |
| image.tag | string | `"0.6.2"` | Target image version tag. |
| image.tag | string | `"0.6.3"` | Target image version tag. |
| imagePullSecrets | list | `[]` | Optional secrets used for pulling the google-cas-issuer container image. |
| nodeSelector | object | `{}` | Kubernetes node selector: node labels for pod assignment |
| podAnnotations | object | `{}` | Optional additional annotations to add to the google-cas-issuer Pods |
Expand Down
2 changes: 1 addition & 1 deletion deploy/charts/google-cas-issuer/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ image:
# -- Target image repository.
repository: quay.io/jetstack/cert-manager-google-cas-issuer
# -- Target image version tag.
tag: 0.6.2
tag: 0.6.3
# -- Kubernetes imagePullPolicy on Deployment.
pullPolicy: IfNotPresent

Expand Down