Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds priorityClassName option to helm chart #124

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Adds priorityClassName option to helm chart #124

merged 1 commit into from
Nov 16, 2022

Conversation

JoshVanL
Copy link
Contributor

@JoshVanL JoshVanL commented Nov 9, 2022

/assign @wallrj

fixes #118

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 9, 2022
jsoref
jsoref approved these changes Nov 9, 2022
View reviewed changes
Copy link

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

irbekrm
irbekrm approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will help with the reported issue where the CSI volumes are not cleaned up, but I guess it does make sense to allow users to set a higher priority on CSI driver pod as it being up might be critical for other workloads to function.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, JoshVanL, jsoref

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit b1a52fe into cert-manager:main Nov 16, 2022
@wallrj wallrj mentioned this pull request Mar 13, 2024
Merged
inteon pushed a commit to inteon/csi-driver that referenced this pull request Dec 11, 2024
@cert-manager-prow
Merge pull request cert-manager#124 from SgtCoDFish/rename-daemonset
71e2bcc 
Rename DaemonSet for easier tab completion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irbekrm irbekrm irbekrm approved these changes

@jsoref jsoref jsoref approved these changes

Assignees

@wallrj wallrj

@irbekrm irbekrm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add priorityClassName to helm chart
5 participants
@JoshVanL @jetstack-bot @jsoref @irbekrm @wallrj