Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priorityClassName to helm chart #118

Closed
Elegant996 opened this issue Oct 5, 2022 · 1 comment · Fixed by #124
Closed

Add priorityClassName to helm chart #118

Elegant996 opened this issue Oct 5, 2022 · 1 comment · Fixed by #124

Comments

@Elegant996
Copy link

On a graceful shutdown, it's possible that the csi-driver would evict before cleaning up the csi volumes. Would it be prudent to add priorityClassName to helm chart to cover that? Clients could then choose whether they need it and set it to system-node-critical or other as needed.

@wallrj
Copy link
Member

wallrj commented Mar 13, 2024

@Elegant996 I've been writing some documentation explaining why to set priorityClassName when deploying cert-manager and what the value should be. Please read and feedback if you have time:

Did you have success using system-node-critical for the cert-manager csi-driver? Do other CSI drivers use or recommend that priority class too?

inteon pushed a commit to inteon/csi-driver that referenced this issue Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants