Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated command with environment file #302

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Replace deprecated command with environment file #302

merged 1 commit into from
Feb 22, 2024

Conversation

jongwooo
Copy link
Contributor

Description

Closes #301

Update workflows to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow files that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

- name: Setup Cache variables
  id: go-cache-paths
  run: |
    echo "::set-output name=go-build::${{ env.GOCACHE }}"
    echo "::set-output name=go-mod::${{ env.GOMODCACHE }}"

TO-BE

- name: Setup Cache variables
  id: go-cache-paths
  shell: bash
  run: |
    echo "go-build=${{ env.GOCACHE }}" >> $GITHUB_OUTPUT
    echo "go-mod=${{ env.GOMODCACHE }}" >> $GITHUB_OUTPUT

@bmsiegel
Copy link
Contributor

This PR ran successfully on my local branch, running testing to make sure nothing is being mutated in the source code, then will merge

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 8f20241 into cert-manager:main Feb 22, 2024
21 of 22 checks passed
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch February 22, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Replace deprecated set-output command with environment file
3 participants