Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

[terra-clinical-onset-picker] Fixes screen reader issues #928

Merged
merged 6 commits into from
Jan 4, 2024

Conversation

sugan2416
Copy link
Contributor

@sugan2416 sugan2416 commented Dec 22, 2023

Summary

Fixes VO issues.

What was changed:

  • Fixes repeated announcement of legend in fields.
  • Fixes repeated announcement of options in dynamically rendered fields.

Why it was changed:

  • Legend was announced twice for each field and when dropdown is opened.
  • Fields rendered after granularity selection had repetitive announcements.

NOTE

Form select (select-field) issues need to be addressed to make onset picker accessible due to repeated announcement of selected item in dropdown.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-10100


Thank you for contributing to Terra.
@cerner/terra

@github-actions github-actions bot temporarily deployed to preview-pr-928 January 4, 2024 08:01 Destroyed
@rahulkumar8cs
Copy link

+1

@sugan2416 sugan2416 merged commit e9094a0 into main Jan 4, 2024
22 checks passed
@sugan2416 sugan2416 deleted the onset-picker-a11y branch January 4, 2024 11:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants