Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

[terra-clinical-onset-picker] Added required prop #927

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

sugan2416
Copy link
Contributor

@sugan2416 sugan2416 commented Dec 14, 2023

Summary

What was changed:

Added required prop to mark fields as required based on granularity level.

Why it was changed:

Added required prop as requested to honor required fields.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-8663


Thank you for contributing to Terra.
@cerner/terra

image image

@github-actions github-actions bot temporarily deployed to preview-pr-927 December 15, 2023 11:54 Destroyed
Copy link
Contributor

@supreethmr supreethmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why required attribute is not added for granularity select :

className={cx('field-inline', 'granularity')}

and Precision select :

className={cx('field-inline', 'precision')}

@sugan2416
Copy link
Contributor Author

Why required attribute is not added for granularity select :

className={cx('field-inline', 'granularity')}

and Precision select :

className={cx('field-inline', 'precision')}

Requirement was to add only to the fields displayed upon granularity selection
image

@supreethmr
Copy link
Contributor

Why required attribute is not added for granularity select :

className={cx('field-inline', 'granularity')}

and Precision select :

className={cx('field-inline', 'precision')}

Requirement was to add only to the fields displayed upon granularity selection image

I don't see it is being added for precision! can you provide me link to precision field with required attribute

@sugan2416
Copy link
Contributor Author

sugan2416 commented Dec 18, 2023

Why required attribute is not added for granularity select :

className={cx('field-inline', 'granularity')}

and Precision select :

className={cx('field-inline', 'precision')}

Requirement was to add only to the fields displayed upon granularity selection image

I don't see it is being added for precision! can you provide me link to precision field with required attribute

We're not adding for both precision and granularity fields. Its for only the fields rendered on granularity selection.
image

@sugan2416 sugan2416 merged commit 3fbfa21 into main Dec 19, 2023
22 checks passed
@sugan2416 sugan2416 deleted the onset-picker-required branch December 19, 2023 10:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants