Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Commit

Permalink
Remove commented out code
Browse files Browse the repository at this point in the history
  • Loading branch information
ry061521 committed Sep 29, 2023
1 parent 7303588 commit 4795247
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 13 deletions.
11 changes: 0 additions & 11 deletions packages/terra-clinical-item-view/src/ItemView.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -103,17 +103,6 @@
float: left;
}

// .content:blank {
// min-height: 1.3em; // Setting a line height so when a blank display is passed in the content maintains it's height instead of shrinking
// }

// .content:empty {
// &::before {
// min-height: 1.3em; // Setting a line height so when a blank display is passed in the content maintains it's height instead of shrinking
// }
// }

// ideally we only want to apply this when the content is blank/empty but I haven't been able to get that to work
.content {
min-height: 1.25em; // Setting a line height so when a blank display is passed in the content maintains it's height instead of shrinking
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ const views = () => (
<h2>Two Column Layout By Row - Left and Right Column with Blank Displays on Different Lines </h2>
<p>
This should have what appears to be a newline when there is a blank display on one side of a `row` - that was the previous behavior for two column layout.
That is because when one column has a display and the other in the same row has an empty display, the height from the populated display spans the entire row and therefore the column with the empty display still has the same height as the other.
That is because when one column has a display and the other in the same row has an empty display, the height from the populated display spans the entire row.
Therefore, the column with the empty display still has the same height as the other.
This means the side with the empty display appears to be an blank newline.
No additonal changes to the css is needed for this, just want an example to show the behavior.
</p>
Expand All @@ -48,7 +49,8 @@ const views = () => (
<h2>Two Column Layout By Row - Left and Right Column with Blank Displays on Same Line </h2>
<p>
This should **not** have what appears to be a newline when there are two blank displays in the same row.
That is because this formatting spans the entire row and therefore if the two blank displays are in the same row, they both have no height and therefore no newline is shown where those would usually be.
That is because this formatting spans the entire row and therefore if the two blank displays are in the same row,
they both have no height and therefore no newline is shown where those would usually be.
</p>
<ItemView displays={bothColumnsBlankDisplaysSameRow} layout="twoColumns" id="test-blank-displays-by-row-same-line" />
<br />
Expand Down

0 comments on commit 4795247

Please sign in to comment.