This repository has been archived by the owner on May 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[terra-clinical-item-view] Fix for null item displays (#924)
- Loading branch information
1 parent
8c7abba
commit 212b64d
Showing
24 changed files
with
79 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,9 @@ | |
|
||
## Unreleased | ||
|
||
* Fixed | ||
* Fixed error for null `displays` prop. | ||
|
||
## 4.13.0 - (October 3, 2023) | ||
|
||
* Added | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
...terra-clinical-item-view/src/terra-dev-site/test/clinical-item-view/NullItemView.test.jsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import React from 'react'; | ||
import classNames from 'classnames/bind'; | ||
import ItemView from '../../../ItemView'; | ||
import styles from './ItemViewCommon.test.module.scss'; | ||
|
||
const cx = classNames.bind(styles); | ||
|
||
const DefaultItemView = () => ( | ||
<div> | ||
<p>Given null displays prop, the div is created, but there is no content to show. The ItemView is outlined below.</p> | ||
<div className={cx('itemview-wrapper')}> | ||
<ItemView id="ItemView" displays={null} /> | ||
</div> | ||
<p>Given null display item, the div is created, but there is no content to show. The ItemView is outlined below.</p> | ||
<div className={cx('itemview-wrapper')}> | ||
<ItemView id="ItemViewNullInput" displays={[null]} /> | ||
</div> | ||
</div> | ||
); | ||
|
||
export default DefaultItemView; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+23 KB
...inical-lowlight-theme/en/chrome_enormous/item-view-spec/with_a_null_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+22.8 KB
...e/clinical-lowlight-theme/en/chrome_huge/item-view-spec/with_a_null_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+22.5 KB
.../clinical-lowlight-theme/en/chrome_large/item-view-spec/with_a_null_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+22.3 KB
...clinical-lowlight-theme/en/chrome_medium/item-view-spec/with_a_null_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+22.4 KB
.../clinical-lowlight-theme/en/chrome_small/item-view-spec/with_a_null_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+22.1 KB
...e/clinical-lowlight-theme/en/chrome_tiny/item-view-spec/with_a_null_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+19.4 KB
...ce/orion-fusion-theme/en/chrome_enormous/item-view-spec/with_a_null_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+19.2 KB
...erence/orion-fusion-theme/en/chrome_huge/item-view-spec/with_a_null_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+18.9 KB
...rence/orion-fusion-theme/en/chrome_large/item-view-spec/with_a_null_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+18.8 KB
...ence/orion-fusion-theme/en/chrome_medium/item-view-spec/with_a_null_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+18.6 KB
...rence/orion-fusion-theme/en/chrome_small/item-view-spec/with_a_null_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+18.6 KB
...erence/orion-fusion-theme/en/chrome_tiny/item-view-spec/with_a_null_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+23.5 KB
...e/terra-default-theme/en/chrome_enormous/item-view-spec/with_a_null_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+23.3 KB
...rence/terra-default-theme/en/chrome_huge/item-view-spec/with_a_null_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+23 KB
...ence/terra-default-theme/en/chrome_large/item-view-spec/with_a_null_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+22.8 KB
...nce/terra-default-theme/en/chrome_medium/item-view-spec/with_a_null_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+22.9 KB
...ence/terra-default-theme/en/chrome_small/item-view-spec/with_a_null_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+22.7 KB
...rence/terra-default-theme/en/chrome_tiny/item-view-spec/with_a_null_display.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions
6
packages/terra-clinical-item-view/tests/wdio/item-view-spec.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters