[terra-clinical-label-value-view] Fix margin for dl elements (#904)

cerner · Aug 29, 2023 · 0b46a98 · 0b46a98
1 parent 2bfc18e
commit 0b46a98
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 0 deletions.
diff --git a/packages/terra-clinical-label-value-view/CHANGELOG.md b/packages/terra-clinical-label-value-view/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+* Fixed
+  * Removed extra top and bottom margins from LabelValueView description list.
+
 ## 3.31.0 - (August 2, 2023)
 
 * Changed

diff --git a/packages/terra-clinical-label-value-view/src/LabelValueView.module.scss b/packages/terra-clinical-label-value-view/src/LabelValueView.module.scss
@@ -6,6 +6,8 @@
 :local {
   .label-value-view {
     border: 0;
+    margin-bottom: 0;
+    margin-top: 0;
     padding: 0;
     word-break: break-word;
     word-wrap: break-word;

diff --git a/...clinical-label-value-view/src/terra-dev-site/doc/example/LabelValueViewTextTermAndDef.jsx b/...clinical-label-value-view/src/terra-dev-site/doc/example/LabelValueViewTextTermAndDef.jsx
@@ -8,6 +8,11 @@ const LabelValueViewText = () => (
         #dl-wrapper > dd {
           margin-bottom: 14px;
         }
+
+        #dl-wrapper {
+          margin-bottom: 0;
+          margin-top: 0;
+        }
       `}
     </style>
     <h4 id="topicText">Vitals</h4>

diff --git a/...e-view/src/terra-dev-site/test/clinical-label-value-view/TextValueLabelValueView.test.jsx b/...e-view/src/terra-dev-site/test/clinical-label-value-view/TextValueLabelValueView.test.jsx
@@ -13,6 +13,11 @@ const examples = () => (
         #dl-wrapper > dd {
           margin-bottom: 14px;
         }
+
+        #dl-wrapper {
+          margin-bottom: 0;
+          margin-top: 0;
+        }
       `}
     </style>
     <h3>LabelValueView returned as a term and a definition (isChildOfDescriptionList=&apos;true&apos;):</h3>

diff --git a/...e/clinical-lowlight-theme/en/chrome_medium/label-value-view-spec/text_value.png b/...e/clinical-lowlight-theme/en/chrome_medium/label-value-view-spec/text_value.png
diff --git a/...rence/terra-default-theme/en/chrome_medium/label-value-view-spec/text_value.png b/...rence/terra-default-theme/en/chrome_medium/label-value-view-spec/text_value.png