This repository has been archived by the owner on May 24, 2024. It is now read-only.
[workspace-v1-epic] Add WorkspaceLayout and SkipTos #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkasper-was-taken
requested review from
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
tbiethman
reviewed
Jul 2, 2021
tbiethman
reviewed
Jul 2, 2021
tbiethman
reviewed
Jul 2, 2021
mjhenkes
reviewed
Jul 2, 2021
mjhenkes
reviewed
Jul 2, 2021
mjhenkes
reviewed
Jul 2, 2021
mjhenkes
reviewed
Jul 2, 2021
mjhenkes
reviewed
Jul 2, 2021
mjhenkes
reviewed
Jul 2, 2021
src/application-navigation/ApplicationNavigationWorkspaceItem.jsx
Outdated
Show resolved
Hide resolved
mjhenkes
reviewed
Jul 2, 2021
mjhenkes
reviewed
Jul 16, 2021
mjhenkes
reviewed
Jul 16, 2021
src/application-navigation/index.js
Outdated
Comment on lines
13
to
17
| // titleConfigPropType, | ||
| // navigationItemsPropType, | ||
| // extensionItemsPropType, | ||
| // utilityItemsPropType, | ||
| // userConfigPropType, |
tbiethman
reviewed
Jul 16, 2021
mjhenkes
reviewed
Jul 16, 2021
src/terra-dev-site/app/how-to.3/create-workspace-content.app.mdx
Outdated
Show resolved
Hide resolved
tbiethman
reviewed
Jul 19, 2021
| @@ -233,6 +237,47 @@ const myNotifications = { | |||
|
|
|||
| `onDrawerMenuStateChange` callback allows the consumer to know state changes in Drawer Menu. | |||
|
|
|||
| ### `workspace` | |||
tbiethman
reviewed
Jul 19, 2021
| @@ -0,0 +1,49 @@ | |||
| import WorkspaceContentProps from 'terra-application/lib/workspace/WorkspaceContent?dev-site-props-table'; | |||
tbiethman
reviewed
Jul 19, 2021
| @@ -0,0 +1,27 @@ | |||
| # ApplicationNavigationActionsContext | |||
tbiethman
reviewed
Jul 19, 2021
| @@ -0,0 +1,343 @@ | |||
| import { Notice } from '@cerner/terra-docs'; | |||
benbcai
reviewed
Jul 19, 2021
src/application-navigation/private/workspace-layout/WorkspaceLayout.jsx
Outdated
Show resolved
Hide resolved
benbcai
reviewed
Jul 19, 2021
src/application-navigation/private/workspace-layout/WorkspaceLayout.module.scss
Outdated
Show resolved
Hide resolved
benbcai
reviewed
Jul 19, 2021
src/terra-dev-site/app/components.2/ApplicationNavigation.app.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben Cai <[email protected]>
mjhenkes
reviewed
Jul 19, 2021
Comment on lines
+14
to
+16
| ```jsx | ||
| import { WorkspaceContent } from 'terra-application/lib/workspace'; | ||
| ``` |
There was a problem hiding this comment.
these usage sections are pretty useless, should we ditch it?
There was a problem hiding this comment.
maybe it's useful in showing the path to get to the workspace component, but thats about it.
There was a problem hiding this comment.
I think that's all they ever did, across all our packages. "Usage" might be the wrong word, but showing the the import path is helpful.
mjhenkes
approved these changes
Jul 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add WorkspaceLayout and SkipTos to local ApplicationNavigation reference..
Closes #232
Closes #224
Deployment Link
https://terra-applic-.herokuapp.com/
Testing
Added jest and wdio test, updated existing application navigation tests.
Thank you for contributing to Terra.
@cerner/terra