-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-protocol support #34
Open
dlenski
wants to merge
31
commits into
cernekee:master
Choose a base branch
from
dlenski:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The various changes to |
@cernekee, any interest in taking a look at this now that all the required machinery is in the official OpenConnect release? |
external: Use the ANDROID_NDK env variable as a default NDK path
Why not compile C++ Project on windows. any one can solve this problem |
Need to use very recent versions of @dlenski's openconnect, incorporating the multi-protocol API into the Java bindings (https://github.com/dlenski/openconnect)
…system/bin/sh Incredibly frustrating… why is this happening? - Possibly because stdin is closed? - Possibly because the output buffer isn't big enough?
Latest LibOpenConnect has two constructors, one of which accepts a User-Agent string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very preliminary take on #28… but it's already working for me with both GlobalProtect and Juniper 😀
TODO:
vpn_protocol
preference list dynamically usingmOC.getSupportedProtocols()
VPNProto.flags
Update docs to reflect multi-protocol support.TheX-CSTP-Idle-Timeout
field should be replaced with a protocol-agnostic field (which doesn't yet exist in the openconnect base)Juniper servers will throw extra authentication applets/trojans at you ifJava
appears in yourUser-Agent
string 🤦♂️ … it'd be good to be able to set theUser-Agent
string.BUGS:
This weird bug with the Juniper realm/authgroup selection also affects the Android GUI…☹️ Connecting to a GlobalProtect portal (rather than gateway) crashes due to some problem with the XML config writeback