OA: parsing each open access category sequentially #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErnestaP
force-pushed
the
fix-fetvhing
branch
2 times, most recently
from
e29f62a to
9b07eca
Compare
drjova
reviewed
Aug 1, 2024
dags/open_access/open_access.py
Outdated
| @@ -1,17 +1,11 @@ | |||
| from functools import reduce | |||
|
|
|||
| import open_access.constants as constants | |||
| import open_access.utils as utils | |||
There was a problem hiding this comment.
let's import the methods that we need and not the whole module :)
dags/open_access/open_access.py
Outdated
| @task(multiple_outputs=True, executor_config=kubernetes_executor_config) | ||
| def join_and_add_year(counts, **kwargs): | ||
| @task(executor_config=kubernetes_executor_config) | ||
| def add_year(green_access, **kwargs): |
There was a problem hiding this comment.
mm.. maybe its a confusing name, the last function that is called- is parsing green access. But each function in a chain adds the data to the final result dict. I will change it
drjova
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.