Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modify cacao, unvalidated module, jwk to add functionality needed for event validation #492

Merged

Conversation

samika98
Copy link
Contributor

@samika98 samika98 commented Aug 19, 2024

modify cacao rs to support event validation : most of the code is pulled in from danny's private data branch : #427
add getters to fetch envelope info needed for validating signed events
support did resolution in jwk : add functionality to resolve a did to extract it's didDocument ( contains signing info like public key needed to verify signature)

…etch enevelope info + support did resolution in jwk
@samika98 samika98 requested review from nathanielc and a team as code owners August 19, 2024 20:05
@samika98 samika98 requested review from PaulLeCam, dav1do and stbrody and removed request for a team August 19, 2024 20:05
@samika98 samika98 temporarily deployed to github-tests-2024 August 19, 2024 20:15 — with GitHub Actions Inactive
Copy link
Contributor

@dav1do dav1do left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, a few comments/more things we'll need, but feel free to comment if you want to skip them and I'll add them in my next PR.

event/src/unvalidated/signed/mod.rs Outdated Show resolved Hide resolved
core/src/jwk.rs Outdated Show resolved Hide resolved
core/src/jwk.rs Outdated Show resolved Hide resolved
event/src/unvalidated/signed/mod.rs Outdated Show resolved Hide resolved
event/src/unvalidated/signed/mod.rs Show resolved Hide resolved
@samika98 samika98 temporarily deployed to github-tests-2024 August 19, 2024 20:37 — with GitHub Actions Inactive
@samika98 samika98 temporarily deployed to github-tests-2024 August 19, 2024 22:35 — with GitHub Actions Inactive
@dav1do dav1do added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit 726ba1c Aug 20, 2024
5 checks passed
@dav1do dav1do deleted the chore/update-unvalidated-types-to-support-event-validation branch August 20, 2024 15:51
@smrz2001 smrz2001 mentioned this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants