Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use python constants for version values, not the environment #576

Closed
wants to merge 0 commits into from
Closed

Use python constants for version values, not the environment #576

wants to merge 0 commits into from

Conversation

gbregman
Copy link
Contributor

Fixes #571

@gbregman gbregman self-assigned this Apr 11, 2024
@gbregman gbregman requested a review from baum April 11, 2024 11:42
baum
baum requested changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@baum baum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous discussion at #572.

@gbregman gbregman requested a review from baum April 12, 2024 20:28
@gbregman gbregman closed this Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baum baum Awaiting requested review from baum

Assignees

@gbregman gbregman

Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use python constants for version values, not the environment
2 participants
@gbregman @baum