When deleting bdev also delete any namespace using it from OMAP. #208
Conversation
There was a problem hiding this comment.
I still think --no-namespaces option is not needed. Your point about "safe mechanism just in case" does not look convincing to me, especially when we are at so early stage of the project, otherwise we would need to add millions of "just in case" options like this.
Another thing I missed in my first review, I don't think it is right to do this in cli. It should be done on the server. One may use grpc instead of cli to configure the gateway.
|
@trociny , adding a mechanism to disable such features is something I learnt from experience. Not once we got stuck with such automatic actions in the field where something went wrong only to realize there was no way to disable them. So I always add such a disabling option. As this is optional the users can just ignore it. I'll get back to you about the other issue of moving the code. I need to consult my teammates about that. |
Fixes ceph#145 Signed-off-by: Gil Bregman <[email protected]>
Fixes #145
The SPDK automatically delete any namespace using a bdev which is deleted. But there is no such mechanism for the OMAP file. So, we need the CLI to take care of that and whenever a bdev is deleted to also delete any namespace using it. The default behavior is to fail the delete_bdev command with EBUSY in case a namespace is still using it. The user should explicitly remove any such namespace. In case "--force" (or "-f") is used in the delete_bdev command line the namespaces would get deleted automatically.