Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(package): move proto dir inside control #179

Merged
merged 1 commit into from
Aug 31, 2023
Merged

fix(package): move proto dir inside control #179

merged 1 commit into from
Aug 31, 2023

Conversation

epuertat
Copy link
Member

Fixes: #178

@epuertat epuertat linked an issue Aug 11, 2023 that may be closed by this pull request
Missing grpc files in stand-alone Python package: "ModuleNotFoundError: No module named 'proto'" #178
Closed
@epuertat epuertat force-pushed the 178-missing-grpc-files-in-stand-alone-python-package-modulenotfounderror-no-module-named-proto branch 4 times, most recently from 4a893d7 to cae9ca4 Compare August 11, 2023 09:02
oritwas
oritwas approved these changes Aug 13, 2023
View reviewed changes
Copy link
Member

@oritwas oritwas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epuertat epuertat force-pushed the 178-missing-grpc-files-in-stand-alone-python-package-modulenotfounderror-no-module-named-proto branch 4 times, most recently from fc00be5 to ebf260a Compare August 14, 2023 17:08
roysahar
roysahar reviewed Aug 30, 2023
View reviewed changes
.env Outdated Show resolved Hide resolved
@epuertat epuertat force-pushed the 178-missing-grpc-files-in-stand-alone-python-package-modulenotfounderror-no-module-named-proto branch 2 times, most recently from d057e52 to cab10c3 Compare August 31, 2023 09:23
@epuertat epuertat force-pushed the 178-missing-grpc-files-in-stand-alone-python-package-modulenotfounderror-no-module-named-proto branch from cab10c3 to 5c6ac22 Compare August 31, 2023 09:23
@epuertat epuertat merged commit 09cb4ad into devel Aug 31, 2023
@epuertat epuertat deleted the 178-missing-grpc-files-in-stand-alone-python-package-modulenotfounderror-no-module-named-proto branch August 31, 2023 09:51
@epuertat epuertat mentioned this pull request Sep 5, 2023
Closed
epuertat added a commit that referenced this pull request Sep 5, 2023
@epuertat
revert(spdk): recover spdk v23.01.1
a74318c 
Fixes #214
Fixes #179

Signed-off-by: Ernesto Puerta <[email protected]>
@epuertat epuertat mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roysahar roysahar roysahar left review comments

@oritwas oritwas oritwas approved these changes

Assignees

@roysahar roysahar

Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing grpc files in stand-alone Python package: "ModuleNotFoundError: No module named 'proto'"
3 participants
@epuertat @oritwas @roysahar