WIP: Enable using host networking for Controller Plugin pods. #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
requested changes
Nov 19, 2024
There was a problem hiding this comment.
@obnoxxx please test both cephfs/rbd with below combination
- cephfs and RBD Driver running on Host network
- cephfs and RBD Driver running on pod network
- cephfs and RBD Driver with csiaddons running on Host hetwork
- cephfs and RBD Driver with csiaddons running on pod network
I expect some port conflict as csiaddons uses same port for cephfs and rbd deployments
obnoxxx
force-pushed
the
host-network
branch
from
ddca2c3
to
6472287
Compare
Madhu-1
reviewed
Nov 21, 2024
| @@ -564,6 +564,7 @@ func (r *driverReconcile) reconcileControllerPluginDeployment() error { | |||
| Strategy: ptr.Deref(pluginSpec.DeploymentStrategy, defaultDeploymentStrategy), | |||
| Template: corev1.PodTemplateSpec{ | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
|
|
|||
There was a problem hiding this comment.
please remove this new line as well.
|
@obnoxxx there is a typo in commit message as well PTAL. |
obnoxxx
force-pushed
the
host-network
branch
2 times, most recently
from
cb6b8e7
to
adee77d
Compare
This bool setting can be added to the controllerPlugin section of the Driver Spec. It will be propagated to all controller plugin pods. This implements the following design: https://github.com/ceph/ceph-csi-operator/blob/main/docs/design/hostNetwork.md Signed-off-by: Michael Adam <[email protected]>
obnoxxx
force-pushed
the
host-network
branch
from
adee77d
to
da919bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
This work in progress is a draft PR for the implementation of host Networking for controller plugin pods as described in https://github.com/ceph/ceph-csi-operator/blob/main/docs/design/hostNetwork.md
Is there anything that requires special attention
This a first draft and still needs to be thoroughly tested.
Is the change backward compatible?
should be but needs testing.
Are there concerns around backward compatibility?
see issue #157 for background and context.
This PR is currently based on PR #175 to let it pass unit tests.
It will need to be rebased should that other PR merge.
Related issues
Fixes: #157
Future concerns
none.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.