Add feedback redesign #2487
Merged
Add feedback redesign #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR deployed in Google Cloud |
|
PR deployed in Google Cloud |
kattylucy
force-pushed
the
2471_feedback_redesign
branch
3 times, most recently
from
517a559 to
5727c81
Compare
kattylucy
force-pushed
the
2471_feedback_redesign
branch
from
5727c81 to
d74b660
Compare
kattylucy
force-pushed
the
2471_feedback_redesign
branch
from
86724f2 to
ffee519
Compare
kattylucy
force-pushed
the
2471_feedback_redesign
branch
from
ffee519 to
2155682
Compare
kattylucy
force-pushed
the
2471_feedback_redesign
branch
from
48701d2 to
8d23257
Compare
| @@ -24,6 +25,10 @@ export type MetaData = { | |||
| } | |||
| } | |||
|
|
|||
| type TinlakeTranchesKey = 'silver' | 'blocktowerThree' | 'blocktowerFour' | |||
There was a problem hiding this comment.
Suggested change
| type TinlakeTranchesKey = 'silver' | 'blocktowerThree' | 'blocktowerFour' | |
| type TinlakeTranchesKey = 'NS3' | 'BT3' | 'BT4' |
| @@ -50,6 +57,33 @@ const StyledCard = styled(Card)` | |||
| } | |||
| ` | |||
|
|
|||
| const tinlakeTranches = { | |||
| silver: { | |||
There was a problem hiding this comment.
Suggested change
| silver: { | |
| NS3: { |
| shortDescription: ' Real estate bridge loans for fix and flip projects, maturing in 12-24 months.', | ||
| InvestorType: 'Qualified Investors', | ||
| }, | ||
| blocktowerThree: { |
There was a problem hiding this comment.
Suggested change
| blocktowerThree: { | |
| BT3: { |
| shortDescription: ' Investment-grade consumer ABS, auto ABS, and CLOs under 4 years.', | ||
| InvestorType: 'Private', | ||
| }, | ||
| blocktowerFour: { |
There was a problem hiding this comment.
Suggested change
| blocktowerFour: { | |
| BT4: { |
| {text} | ||
| </Text> | ||
| ) | ||
| const isTinlakePool = |
There was a problem hiding this comment.
Suggested change
| const isTinlakePool = | |
| const isTinlakePool = poolId.startsWith('0x') |
this should be enough since only tinlake pools have hex coded IDs
| }) | ||
| .reverse() | ||
| const tinlakeObjKey = () => { | ||
| if (name?.includes('Silver')) return 'silver' |
There was a problem hiding this comment.
Suggested change
| if (name?.includes('Silver')) return 'silver' | |
| if (name?.includes('New Silver 3')) return 'NS3' |
I think you need to be more specific here since we have two other New Silver pools (in the archive)
| .reverse() | ||
| const tinlakeObjKey = () => { | ||
| if (name?.includes('Silver')) return 'silver' | ||
| else if (name?.includes('BlockTower Series 3')) return 'blocktowerThree' |
There was a problem hiding this comment.
Suggested change
| else if (name?.includes('BlockTower Series 3')) return 'blocktowerThree' | |
| else if (name?.includes('BlockTower Series 3')) return 'BT3' |
| const tinlakeObjKey = () => { | ||
| if (name?.includes('Silver')) return 'silver' | ||
| else if (name?.includes('BlockTower Series 3')) return 'blocktowerThree' | ||
| else if (name?.includes('BlockTower Series 4')) return 'blocktowerFour' |
There was a problem hiding this comment.
Suggested change
| else if (name?.includes('BlockTower Series 4')) return 'blocktowerFour' | |
| else if (name?.includes('BlockTower Series 4')) return 'BT4' |
sophialittlejohn
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2471
#2484