Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Nav Management dynamic Card #2441

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

sophialittlejohn
Copy link
Collaborator

Description

Screenshot 2024-09-09 at 17 41 03

This pull request... adjust the numbers in the nav management card so that they're dynamic to the imports (feature requested by product)

#

Approvals

  • Dev

Screenshots

Impact

Copy link

github-actions bot commented Sep 9, 2024

PR deployed in Google Cloud
URL: https://app-pr2441.k-f.dev
Commit #: 322d8d4
To access the functions directly check the corresponding deploy Action

Copy link

github-actions bot commented Sep 9, 2024

PR deployed in Google Cloud
URL: https://pr2441-app-ff-production.k-f.dev
Commit #: 322d8d4
To access the functions directly check the corresponding deploy Action

* wip: try fixing values

* wip: try fixing build

* wip: try fixing number conversion

* fix errors

* wip: make numbers correct

* Align nav managment tables on page and drawer

---------

Co-authored-by: Onno Visser <[email protected]>
Co-authored-by: sophian <[email protected]>
@sophialittlejohn sophialittlejohn merged commit 9a67cb2 into hotfix-nav-management Sep 10, 2024
10 checks passed
@sophialittlejohn sophialittlejohn deleted the hotfix-nav-management-actual branch September 10, 2024 18:58
sophialittlejohn added a commit that referenced this pull request Sep 11, 2024
* Hotfix: finance form validation, subql self hosted, withdraw batch fix (#2436)

* Point subquery to new version

* Fix pending NAV calc

* Fix mistake in subquery urls

* Fix withdraw address validation

* Include withdraw batch only where necessary

* Undo accidental commit

* Revalidate forms when source changes

* Add cursor based pagination for asset transactions (#2438)

* Hotfix: Nav Management dynamic Card (#2441)

* Make change asset in asset valuation dynamic

* Fix nav management card value in Drawer (#2442)

* wip: try fixing values

* wip: try fixing build

* wip: try fixing number conversion

* fix errors

* wip: make numbers correct

* Align nav managment tables on page and drawer

---------

Co-authored-by: Onno Visser <[email protected]>
Co-authored-by: sophian <[email protected]>

---------

Co-authored-by: Frederik Gartenmeister <[email protected]>
Co-authored-by: Onno Visser <[email protected]>

---------

Co-authored-by: Frederik Gartenmeister <[email protected]>
Co-authored-by: Onno Visser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants