Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UUID api error #3

Merged
merged 3 commits into from
Apr 17, 2018

Conversation

kSpacer201
Copy link
Contributor

when I play the exmaple :

examples\events\main.go

it returns:

#github.com/centrifugal/centrifuge
..\..\client.go:118:23: multiple-value uuid.NewV4() in single-value context
..\..\node.go:62:22: multiple-value uuid.NewV4() in single-value context

fix a error : client.go:118:23: multiple-value uuid.NewV4() in single-value context
@FZambia
Copy link
Member

FZambia commented Apr 17, 2018

Hello @kSpacer201 , thanks! Looks like Go dependency management problem and recent change in uuid lib public API :)

@FZambia FZambia merged commit b4f78cb into centrifugal:master Apr 17, 2018
@FZambia
Copy link
Member

FZambia commented Apr 17, 2018

@kSpacer201 have you used dep when run example by the way? It must handle this case correctly when installing all required dependencies.

I also updated master branch to fit changes and a bit refactored to panic when error occurres during node creation and now handle error after newClient call.

@kSpacer201 kSpacer201 deleted the fix-uuid-api-error branch April 18, 2018 03:28
@kSpacer201 kSpacer201 restored the fix-uuid-api-error branch April 18, 2018 03:31
@kSpacer201
Copy link
Contributor Author

Oh , I see . As I am in China , and cann't access the google site . So I handled all the package with go get and some with manually.

I will try to about using dep .Thanks for your awesome project.

@FZambia
Copy link
Member

FZambia commented Apr 18, 2018

Welcome! I am very interested in feedback from you btw (even negative) as this lib is on very early stage.

@kSpacer201
Copy link
Contributor Author

Yeah , maybe I should to make some mirrors to boost the downloading process and make it easier to be GOing. It sounds great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants