Dropdown Expandable - QA review tweaks from Laura and Orion #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-cedrone-cengage
requested review from
silvalaura and
a team
as code owners
🦋 Changeset detectedLatest commit: 7790ab5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
silvalaura
reviewed
Oct 18, 2023
packages/react-magma-dom/src/components/Dropdown/Dropdown.test.js
Outdated
Show resolved
Hide resolved
…pandableMenuButton
silvalaura
reviewed
Oct 18, 2023
packages/react-magma-dom/src/components/Dropdown/DropdownExpandableMenuButton.tsx
Outdated
Show resolved
Hide resolved
silvalaura
approved these changes
Oct 18, 2023
orion-cengage
requested changes
Oct 19, 2023
There was a problem hiding this comment.
I don't think the following feedback was addressed:
- There should only be 8px of padding at the top and bottom of the dropdown container. It looks like there is some extra padding being applied on a div inside that container, making the padding actually look more like 12px or 16px.
silvalaura
reviewed
Oct 19, 2023
| const StyledDiv = styled.div` | ||
| padding: ${props => props.theme.spaceScale.spacing02} 0; | ||
| `; | ||
| const StyledDiv = styled.div``; |
There was a problem hiding this comment.
Since it's not styled... can we remove this and just use <div> in line 154?
silvalaura
approved these changes
Oct 19, 2023
orion-cengage
approved these changes
Oct 19, 2023
silvalaura
pushed a commit
that referenced
this pull request
Oct 19, 2023
silvalaura
pushed a commit
that referenced
this pull request
Oct 23, 2023
silvalaura
pushed a commit
that referenced
this pull request
Jun 5, 2024
silvalaura
pushed a commit
that referenced
this pull request
Aug 15, 2024
silvalaura
pushed a commit
that referenced
this pull request
Sep 18, 2024
silvalaura
pushed a commit
that referenced
this pull request
Sep 18, 2024
silvalaura
pushed a commit
that referenced
this pull request
Sep 18, 2024
silvalaura
pushed a commit
that referenced
this pull request
Sep 18, 2024
silvalaura
pushed a commit
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: # 1014
What I did
Checklist
How to test