Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CarbonCharts): Support Carbon Charts #1051

Merged
merged 41 commits into from
May 13, 2024
Merged

feat(CarbonCharts): Support Carbon Charts #1051

merged 41 commits into from
May 13, 2024

Conversation

silvalaura
Copy link
Collaborator

@silvalaura silvalaura commented Apr 25, 2023

Issue: #1052 #1033 #1278 #1053

What I did

Bringing in Carbon Charts into @react-magma/charts.

Screenshots (if appropriate):

image
image
image

Checklist

  • changeset has been added
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

How to test

Navigate to Carbon Charts in the docs site or storybook

@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2023

🦋 Changeset detected

Latest commit: b4f5b01

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silvalaura silvalaura linked an issue Apr 25, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

@silvalaura silvalaura added draft Pull requests that are drafts and not ready for review do not merge Pull requests that should not be merged labels May 9, 2023
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

…test, then I fixed Laura's updates, let's see what happens
@github-actions
Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

@silvalaura silvalaura marked this pull request as ready for review May 13, 2024 15:10
@silvalaura silvalaura requested a review from a team as a code owner May 13, 2024 15:10
@silvalaura silvalaura merged commit 1bb49bb into dev May 13, 2024
2 checks passed
@silvalaura silvalaura deleted the feat/CarbonCharts branch May 13, 2024 15:18
@silvalaura silvalaura restored the feat/CarbonCharts branch May 30, 2024 15:00
silvalaura added a commit that referenced this pull request Jun 5, 2024
Co-authored-by: Chris Cedrone <[email protected]>
Co-authored-by: ccedrone <[email protected]>
Co-authored-by: vverein <[email protected]>
silvalaura added a commit that referenced this pull request Jun 5, 2024
Co-authored-by: Chris Cedrone <[email protected]>
Co-authored-by: ccedrone <[email protected]>
Co-authored-by: vverein <[email protected]>
@silvalaura silvalaura deleted the feat/CarbonCharts branch June 20, 2024 15:34
silvalaura added a commit that referenced this pull request Aug 15, 2024
Co-authored-by: Chris Cedrone <[email protected]>
Co-authored-by: ccedrone <[email protected]>
Co-authored-by: vverein <[email protected]>
silvalaura added a commit that referenced this pull request Sep 18, 2024
Co-authored-by: Chris Cedrone <[email protected]>
Co-authored-by: ccedrone <[email protected]>
Co-authored-by: vverein <[email protected]>
silvalaura added a commit that referenced this pull request Sep 18, 2024
Co-authored-by: Chris Cedrone <[email protected]>
Co-authored-by: ccedrone <[email protected]>
Co-authored-by: vverein <[email protected]>
silvalaura added a commit that referenced this pull request Sep 18, 2024
Co-authored-by: Chris Cedrone <[email protected]>
Co-authored-by: ccedrone <[email protected]>
Co-authored-by: vverein <[email protected]>
silvalaura added a commit that referenced this pull request Sep 18, 2024
Co-authored-by: Chris Cedrone <[email protected]>
Co-authored-by: ccedrone <[email protected]>
Co-authored-by: vverein <[email protected]>
silvalaura added a commit that referenced this pull request Sep 18, 2024
Co-authored-by: Chris Cedrone <[email protected]>
Co-authored-by: ccedrone <[email protected]>
Co-authored-by: vverein <[email protected]>
silvalaura added a commit that referenced this pull request Sep 18, 2024
Co-authored-by: Chris Cedrone <[email protected]>
Co-authored-by: ccedrone <[email protected]>
Co-authored-by: vverein <[email protected]>
silvalaura added a commit that referenced this pull request Dec 16, 2024
Co-authored-by: Chris Cedrone <[email protected]>
Co-authored-by: ccedrone <[email protected]>
Co-authored-by: vverein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants