[max/pd] Further data type conversion fixes for audio parameter

celtera · Oct 30, 2022 · fc003f8 · fc003f8
1 parent f4a1417
commit fc003f8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/include/avnd/binding/max/audio_processor.hpp b/include/avnd/binding/max/audio_processor.hpp
@@ -143,7 +143,7 @@ struct audio_processor
           // but most pd externals seem to just do a chain of if() so this is equivalent
           float res = argv[0].a_w.w_float;
           avnd::pfr::for_each_field(state.inputs, [s, res, &state]<typename C>(C& ctl) {
-            if constexpr(requires { ctl.value = float{}; })
+            if constexpr(avnd::float_parameter<C> || avnd::int_parameter<C> || avnd::bool_parameter<C>)
             {
               constexpr std::string_view control_name = avnd::get_name<C>();
               if(control_name == s->s_name)
@@ -161,7 +161,7 @@ struct audio_processor
         // but most pd externals seem to just do a chain of if() so this is equivalent
         int res = argv[0].a_w.w_long;
         avnd::pfr::for_each_field(state.inputs, [s, res, &state]<typename C>(C& ctl) {
-          if constexpr(avnd::int_parameter<C> || avnd::float_parameter<C> || avnd::enum_parameter<C>)
+          if constexpr(avnd::int_parameter<C> || avnd::float_parameter<C> || avnd::enum_parameter<C> || avnd::bool_parameter<C>)
           {
             constexpr std::string_view control_name = avnd::get_name<C>();
             if(control_name == s->s_name)

diff --git a/include/avnd/binding/pd/audio_processor.hpp b/include/avnd/binding/pd/audio_processor.hpp
@@ -171,7 +171,9 @@ struct audio_processor
           // but most pd externals seem to just do a chain of if() so this is equivalent
           float res = argv[0].a_w.w_float;
           avnd::for_each_field_ref(state.inputs, [s, res, &state]<typename C>(C& ctl) {
-            if constexpr(requires { ctl.value = float{}; })
+            if constexpr(
+                avnd::float_parameter<
+                    C> || avnd::int_parameter<C> || avnd::bool_parameter<C>)
             {
               constexpr std::string_view control_name = avnd::get_name<C>();
               if(control_name == s->s_name)