Skip to content

Commit

Permalink
FIX: Disable boldref-space outputs unless requested (nipreps#3159)
Browse files Browse the repository at this point in the history
If `--level full`, boldref-space outputs are generated. This is due to a
misplaced logical OR instead of AND. The intended effect of the line was
to disable boldref-space outputs unless `level == 'full'`.
  • Loading branch information
effigies authored Nov 28, 2023
2 parents 87a90dd + 904038c commit 3c836e8
Show file tree
Hide file tree
Showing 7 changed files with 1 addition and 33 deletions.
8 changes: 0 additions & 8 deletions .circleci/ds005_fasttrack_outputs.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,12 @@ sub-01/anat/sub-01_hemi-R_desc-reg_sphere.surf.gii
sub-01/anat/sub-01_hemi-R_space-fsLR_desc-msmsulc_sphere.surf.gii
sub-01/anat/sub-01_hemi-R_space-fsLR_desc-reg_sphere.surf.gii
sub-01/func
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-brain_mask.json
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-brain_mask.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-confounds_timeseries.json
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-confounds_timeseries.tsv
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-coreg_boldref.json
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-coreg_boldref.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-hmc_boldref.json
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-hmc_boldref.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-preproc_bold.json
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-preproc_bold.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-01_from-boldref_to-T1w_mode-image_desc-coreg_xfm.json
sub-01/func/sub-01_task-mixedgamblestask_run-01_from-boldref_to-T1w_mode-image_desc-coreg_xfm.txt
sub-01/func/sub-01_task-mixedgamblestask_run-01_from-orig_to-boldref_mode-image_desc-hmc_xfm.json
Expand All @@ -45,16 +41,12 @@ sub-01/func/sub-01_task-mixedgamblestask_run-01_hemi-R_space-fsaverage5_bold.fun
sub-01/func/sub-01_task-mixedgamblestask_run-01_hemi-R_space-fsaverage5_bold.json
sub-01/func/sub-01_task-mixedgamblestask_run-01_hemi-R_space-fsnative_bold.func.gii
sub-01/func/sub-01_task-mixedgamblestask_run-01_hemi-R_space-fsnative_bold.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-brain_mask.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-brain_mask.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-confounds_timeseries.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-confounds_timeseries.tsv
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-coreg_boldref.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-coreg_boldref.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-hmc_boldref.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-hmc_boldref.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-preproc_bold.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-preproc_bold.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-T1w_mode-image_desc-coreg_xfm.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-T1w_mode-image_desc-coreg_xfm.txt
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-orig_to-boldref_mode-image_desc-hmc_xfm.json
Expand Down
8 changes: 0 additions & 8 deletions .circleci/ds005_outputs.txt
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,12 @@ sub-01/anat/sub-01_label-CSF_probseg.nii.gz
sub-01/anat/sub-01_label-GM_probseg.nii.gz
sub-01/anat/sub-01_label-WM_probseg.nii.gz
sub-01/func
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-brain_mask.json
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-brain_mask.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-confounds_timeseries.json
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-confounds_timeseries.tsv
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-coreg_boldref.json
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-coreg_boldref.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-hmc_boldref.json
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-hmc_boldref.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-preproc_bold.json
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-preproc_bold.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-01_from-boldref_to-T1w_mode-image_desc-coreg_xfm.json
sub-01/func/sub-01_task-mixedgamblestask_run-01_from-boldref_to-T1w_mode-image_desc-coreg_xfm.txt
sub-01/func/sub-01_task-mixedgamblestask_run-01_from-orig_to-boldref_mode-image_desc-hmc_xfm.json
Expand All @@ -65,16 +61,12 @@ sub-01/func/sub-01_task-mixedgamblestask_run-01_hemi-R_space-fsaverage5_bold.fun
sub-01/func/sub-01_task-mixedgamblestask_run-01_hemi-R_space-fsaverage5_bold.json
sub-01/func/sub-01_task-mixedgamblestask_run-01_hemi-R_space-fsnative_bold.func.gii
sub-01/func/sub-01_task-mixedgamblestask_run-01_hemi-R_space-fsnative_bold.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-brain_mask.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-brain_mask.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-confounds_timeseries.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-confounds_timeseries.tsv
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-coreg_boldref.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-coreg_boldref.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-hmc_boldref.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-hmc_boldref.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-preproc_bold.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-preproc_bold.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-T1w_mode-image_desc-coreg_xfm.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-T1w_mode-image_desc-coreg_xfm.txt
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-orig_to-boldref_mode-image_desc-hmc_xfm.json
Expand Down
4 changes: 0 additions & 4 deletions .circleci/ds005_partial_fasttrack_outputs.txt
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,12 @@ sub-01/fmap/sub-01_run-02_fmapid-auto00000_desc-magnitude_fieldmap.nii.gz
sub-01/fmap/sub-01_run-02_fmapid-auto00000_desc-preproc_fieldmap.json
sub-01/fmap/sub-01_run-02_fmapid-auto00000_desc-preproc_fieldmap.nii.gz
sub-01/func
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-brain_mask.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-brain_mask.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-confounds_timeseries.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-confounds_timeseries.tsv
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-coreg_boldref.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-coreg_boldref.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-hmc_boldref.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-hmc_boldref.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-preproc_bold.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-preproc_bold.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-T1w_mode-image_desc-coreg_xfm.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-T1w_mode-image_desc-coreg_xfm.txt
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-auto00000_mode-image_xfm.json
Expand Down
4 changes: 0 additions & 4 deletions .circleci/ds005_partial_outputs.txt
Original file line number Diff line number Diff line change
Expand Up @@ -73,16 +73,12 @@ sub-01/fmap/sub-01_run-02_fmapid-auto00000_desc-magnitude_fieldmap.nii.gz
sub-01/fmap/sub-01_run-02_fmapid-auto00000_desc-preproc_fieldmap.json
sub-01/fmap/sub-01_run-02_fmapid-auto00000_desc-preproc_fieldmap.nii.gz
sub-01/func
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-brain_mask.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-brain_mask.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-confounds_timeseries.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-confounds_timeseries.tsv
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-coreg_boldref.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-coreg_boldref.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-hmc_boldref.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-hmc_boldref.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-preproc_bold.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-preproc_bold.nii.gz
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-auto00000_mode-image_xfm.json
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-auto00000_mode-image_xfm.txt
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-T1w_mode-image_desc-coreg_xfm.json
Expand Down
4 changes: 0 additions & 4 deletions .circleci/ds210_fasttrack_outputs.txt
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ sub-02/func/sub-02_task-cuedSGT_run-01_desc-coreg_boldref.json
sub-02/func/sub-02_task-cuedSGT_run-01_desc-coreg_boldref.nii.gz
sub-02/func/sub-02_task-cuedSGT_run-01_desc-hmc_boldref.json
sub-02/func/sub-02_task-cuedSGT_run-01_desc-hmc_boldref.nii.gz
sub-02/func/sub-02_task-cuedSGT_run-01_desc-preproc_bold.json
sub-02/func/sub-02_task-cuedSGT_run-01_desc-preproc_bold.nii.gz
sub-02/func/sub-02_task-cuedSGT_run-01_echo-1_desc-preproc_bold.json
sub-02/func/sub-02_task-cuedSGT_run-01_echo-1_desc-preproc_bold.nii.gz
sub-02/func/sub-02_task-cuedSGT_run-01_echo-2_desc-preproc_bold.json
Expand All @@ -45,8 +43,6 @@ sub-02/func/sub-02_task-cuedSGT_run-01_from-boldref_to-T1w_mode-image_desc-coreg
sub-02/func/sub-02_task-cuedSGT_run-01_from-boldref_to-T1w_mode-image_desc-coreg_xfm.txt
sub-02/func/sub-02_task-cuedSGT_run-01_from-orig_to-boldref_mode-image_desc-hmc_xfm.json
sub-02/func/sub-02_task-cuedSGT_run-01_from-orig_to-boldref_mode-image_desc-hmc_xfm.txt
sub-02/func/sub-02_task-cuedSGT_run-01_space-boldref_T2starmap.json
sub-02/func/sub-02_task-cuedSGT_run-01_space-boldref_T2starmap.nii.gz
sub-02/func/sub-02_task-cuedSGT_run-01_space-MNI152NLin2009cAsym_boldref.nii.gz
sub-02/func/sub-02_task-cuedSGT_run-01_space-MNI152NLin2009cAsym_desc-brain_mask.nii.gz
sub-02/func/sub-02_task-cuedSGT_run-01_space-MNI152NLin2009cAsym_desc-preproc_bold.json
Expand Down
4 changes: 0 additions & 4 deletions .circleci/ds210_outputs.txt
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ sub-02/func/sub-02_task-cuedSGT_run-01_desc-coreg_boldref.json
sub-02/func/sub-02_task-cuedSGT_run-01_desc-coreg_boldref.nii.gz
sub-02/func/sub-02_task-cuedSGT_run-01_desc-hmc_boldref.json
sub-02/func/sub-02_task-cuedSGT_run-01_desc-hmc_boldref.nii.gz
sub-02/func/sub-02_task-cuedSGT_run-01_desc-preproc_bold.json
sub-02/func/sub-02_task-cuedSGT_run-01_desc-preproc_bold.nii.gz
sub-02/func/sub-02_task-cuedSGT_run-01_echo-1_desc-preproc_bold.json
sub-02/func/sub-02_task-cuedSGT_run-01_echo-1_desc-preproc_bold.nii.gz
sub-02/func/sub-02_task-cuedSGT_run-01_echo-2_desc-preproc_bold.json
Expand All @@ -55,8 +53,6 @@ sub-02/func/sub-02_task-cuedSGT_run-01_from-boldref_to-T1w_mode-image_desc-coreg
sub-02/func/sub-02_task-cuedSGT_run-01_from-boldref_to-T1w_mode-image_desc-coreg_xfm.txt
sub-02/func/sub-02_task-cuedSGT_run-01_from-orig_to-boldref_mode-image_desc-hmc_xfm.json
sub-02/func/sub-02_task-cuedSGT_run-01_from-orig_to-boldref_mode-image_desc-hmc_xfm.txt
sub-02/func/sub-02_task-cuedSGT_run-01_space-boldref_T2starmap.json
sub-02/func/sub-02_task-cuedSGT_run-01_space-boldref_T2starmap.nii.gz
sub-02/func/sub-02_task-cuedSGT_run-01_space-MNI152NLin2009cAsym_boldref.nii.gz
sub-02/func/sub-02_task-cuedSGT_run-01_space-MNI152NLin2009cAsym_desc-brain_mask.nii.gz
sub-02/func/sub-02_task-cuedSGT_run-01_space-MNI152NLin2009cAsym_desc-preproc_bold.json
Expand Down
2 changes: 1 addition & 1 deletion fmriprep/workflows/bold/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ def init_bold_wf(
]) # fmt:skip

boldref_out = bool(nonstd_spaces.intersection(('func', 'run', 'bold', 'boldref', 'sbref')))
boldref_out |= config.workflow.level == 'full'
boldref_out &= config.workflow.level == 'full'
echos_out = multiecho and config.execution.me_output_echos

if boldref_out or echos_out:
Expand Down

0 comments on commit 3c836e8

Please sign in to comment.