Feature/celo cip 64 support #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronmgdr
reviewed
Oct 2, 2023
aaronmgdr
reviewed
Oct 2, 2023
|
apart from the ordering comments looking good |
src/chains/celo/serializers.ts
Outdated
Comment on lines
29
to
34
| if ('maxFeePerGas' in tx && 'maxPriorityFeePerGas' in tx) { | ||
| // process as CIP42 if any of these fields are present. realistically gatewayfee is not used but is part of spec | ||
| if ( | ||
| 'gatewayFee' in tx || | ||
| 'gatewayFeeRecipient' in tx || | ||
| ('feeCurrency' in tx && tx.type && tx.type === 'cip42') |
There was a problem hiding this comment.
I wouldn't remove isCIP42, I'd have a isCIP64 method to hide implementation details here
if (isCIP4(tx)) {
return serializeTransactionCIP64(
tx as TransactionSerializableCIP64,
signature,
)
}
if (isCIP42(tx)) {
...
}
yerdua
force-pushed
the
feature/celo-cip-64-support
branch
from
5230db1 to
fe47e3d
Compare
size-limit report 📦
|
yerdua
commented
Oct 20, 2023
src/chains/celo/formatters.test.ts
Outdated
| "from": "0x045d685d23e8aa34dc408a66fb408f20dc84d785", | ||
| "gas": 1527520n, | ||
| "gasPrice": 562129081n, | ||
| "gatewayFee": "0x0", |
There was a problem hiding this comment.
I don't know why or if this change is needed. I'd like confirmation about whether this change was right, or if I broke something elsewhere.
There was a problem hiding this comment.
A test is failing at src/actions/public/getBlock.test.ts:54:27, in a way that looks the same as this. So, I'm inclined to believe that I somehow broke this.
|
Would love to see this PR'd upstream into Viem! |
* auto-publish provenance statements on release * undo quotation accidental format
Thanks for the encouragement! PR for upstream is here: wevm#1379 |
|
closing in favor of wevm#1379 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.