Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applies Yarn 4.x .gitignore settings #168

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

arthurgousset
Copy link
Contributor

@arthurgousset arthurgousset commented Mar 29, 2024

Description

Other changes

  • Locks @celo/... package dependencies

    Short-term fix until we upgrade the dependencies to the correct version.

    Should have committed and merged this change as part of this PR: Fix fadeOutAmong bug when sending CELO #167

    But, I moved a little faster to get the changes into production to prevent faucet abuse. Forgot to commit it on that branch

Tested

Not tested. Manual testing once deployed as usual.

Related issues

Backwards compatibility

Yes

Documentation

None

To avoid resolution conflict. We'll update versions later
Copied the setting for "If you're not using Zero-Installs" from the official Yarn 4.x documentation.

Source: https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored

Context regarding "Zero-installs": https://yarnpkg.com/features/caching#zero-installs
This was mistakenly committed in the past and is not necessary.

> `.yarn/install-state.gz` is an optimization file that you shouldn't ever have to commit. It simply stores the exact state of your project so that the next commands can boot without having to resolve your workspaces all over again.

Source: https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored
@arthurgousset arthurgousset requested a review from a team as a code owner March 29, 2024 17:30
Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
faucet ✅ Ready (Inspect) Visit Preview Mar 29, 2024 5:30pm

@arthurgousset arthurgousset self-assigned this Mar 29, 2024
@arthurgousset arthurgousset changed the title Add Yarn 4.x gitignore settings and deletes install-state.gz Applies Yarn 4.x .gitignore settings Mar 29, 2024
Copy link
Member

@aaronmgdr aaronmgdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super

@arthurgousset arthurgousset merged commit 2746bb4 into master Mar 29, 2024
7 checks passed
@arthurgousset arthurgousset deleted the arthurgousset/gitignore-yarn-files branch March 29, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants