Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lerna #58

Merged
merged 11 commits into from
Jan 12, 2024
Merged

Remove lerna #58

merged 11 commits into from
Jan 12, 2024

Conversation

shazarre
Copy link
Contributor

Description

This PR aims to remove lerna for working with workspaces in favor of using native yarn support.

Tested

Ran the commands locally.

Backwards compatibility

Changes should be backwards compatible as the top-level commands stayed the same, they're just invoking yarn workspaces instead of lerna.

Copy link

changeset-bot bot commented Jan 11, 2024

⚠️ No Changeset found

Latest commit: 1b34208

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

package.json Outdated Show resolved Hide resolved
@aaronmgdr
Copy link
Member

have you done a project wide search for lerna? i feel like there should be more places it was invoked

Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: [email protected]

@shazarre shazarre marked this pull request as ready for review January 12, 2024 14:56
@shazarre shazarre requested a review from a team as a code owner January 12, 2024 14:56
Copy link
Member

@aaronmgdr aaronmgdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛳️

@shazarre shazarre merged commit 4bce1a8 into master Jan 12, 2024
16 checks passed
@shazarre shazarre deleted the shazarre/remove_lerna branch January 12, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants