Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this gives us much more readable output in the terminal #454

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aaronmgdr
Copy link
Member

@aaronmgdr aaronmgdr commented Nov 21, 2024

Description

do you suffer trying to find the test failures in a sea of console log?

Other changes

--node test was too flakey


PR-Codex overview

This PR primarily focuses on enhancing test reliability and clarity by clearing mocks before each test and improving error handling in the status command. It also refines the logging behavior in various test files.

Detailed summary

  • Updated logMock and writeMock to use mockClear() in multiple test files.
  • Improved error handling in packages/cli/src/commands/validator/status.ts for null blocks.
  • Added beforeEach in setupAfterEnv.ts to mock console methods.
  • Refined mock implementations in status.test.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.77%. Comparing base (9558b56) to head (573d160).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
- Coverage   69.81%   69.77%   -0.05%     
==========================================
  Files         292      292              
  Lines       11206    11209       +3     
  Branches     1664     1680      +16     
==========================================
- Hits         7824     7821       -3     
- Misses       3279     3320      +41     
+ Partials      103       68      -35     
Components Coverage Δ
celocli 74.18% <33.33%> (-0.03%) ⬇️
dev-utils ∅ <ø> (∅)
sdk ∅ <ø> (∅)
wallets ∅ <ø> (∅)
viem-sdks ∅ <ø> (∅)
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant