Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network:contracts fix #150

Merged
merged 2 commits into from
Feb 22, 2024
Merged

network:contracts fix #150

merged 2 commits into from
Feb 22, 2024

Conversation

aaronmgdr
Copy link
Member

@aaronmgdr aaronmgdr commented Feb 21, 2024

Description

While before we relied on a static list of which contracts were unproxied, since that can be different across networks instead just catch the failed call, and set to none.

Other changes

figured out how to test the output of oclif commands

Tested

added test for the command

Related issues

Backwards compatibility

you bet

Documentation

n/a

@aaronmgdr aaronmgdr requested a review from a team as a code owner February 21, 2024 15:12
Copy link

changeset-bot bot commented Feb 21, 2024

🦋 Changeset detected

Latest commit: 9b30ad4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@celo/celocli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aaronmgdr aaronmgdr changed the title Aaronmgdr/baklava network:contracts fix Feb 21, 2024
Copy link
Contributor

@nicolasbrugneaux nicolasbrugneaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clear and to the point. love the snapshots too

@aaronmgdr aaronmgdr merged commit 6157c6d into master Feb 22, 2024
18 checks passed
@aaronmgdr aaronmgdr deleted the aaronmgdr/baklava branch February 22, 2024 12:37
@github-actions github-actions bot mentioned this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants