-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
### Description add alias for celoLegacy to derivationPath flag on account:new command This is currently same behavior as the default but that will change in a future version. #### Other changes shift imports to be direct from celo/base instead of reexported from cryptographic utils ### Related issues - part of #448 <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces enhancements to the `account:new` command in the Celo CLI, including new derivation path aliases and improved output for the BIP44 derivation path. It also updates documentation and ensures better error handling for invalid derivation paths. ### Detailed summary - Added `DerivationPathAliases` enum with `eth` and `celoLegacy`. - Updated `account:new` command to support new derivation path aliases. - Improved output to include full BIP44 derivation path. - Updated documentation for `--derivationPath` flag. - Enhanced error handling for invalid derivation paths. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
- Loading branch information
Showing
18 changed files
with
238 additions
and
56 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@celo/celocli': patch | ||
--- | ||
|
||
when account:new is called it displays the full bip44 derivation path in the output. Before it would miss the last 2 positions. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@celo/base': minor | ||
--- | ||
|
||
add DerivationPathAliases export |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@celo/celocli': minor | ||
--- | ||
|
||
For `account:new` command add alias "celoLegacy" to the `--derivationPath` flag | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
[@celo/base](../README.md) / [account](../modules/account.md) / DerivationPathAliases | ||
|
||
# Enumeration: DerivationPathAliases | ||
|
||
[account](../modules/account.md).DerivationPathAliases | ||
|
||
## Table of contents | ||
|
||
### Enumeration Members | ||
|
||
- [celoLegacy](account.DerivationPathAliases.md#celolegacy) | ||
- [eth](account.DerivationPathAliases.md#eth) | ||
|
||
## Enumeration Members | ||
|
||
### celoLegacy | ||
|
||
• **celoLegacy** = ``"m/44'/52752'/0'"`` | ||
|
||
#### Defined in | ||
|
||
[packages/sdk/base/src/account.ts:7](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/base/src/account.ts#L7) | ||
|
||
___ | ||
|
||
### eth | ||
|
||
• **eth** = ``"m/44'/60'/0'"`` | ||
|
||
#### Defined in | ||
|
||
[packages/sdk/base/src/account.ts:6](https://github.com/celo-org/developer-tooling/blob/master/packages/sdk/base/src/account.ts#L6) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.