Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I can't take it anymore. We need to do a full release cycle every time we an SSL Fingerprint changes, and on top of that we've moved away from using leaf SSL fingerprints to do this less often, thus being less secure in practice.
This PR adds the long awaited dynamic configuration of SSL certificates from a global source of truth, and what better source of truth than a blockchain! So first head over to the new Oracle SSL Fingerprint Registry.
The implementation is quite simple, there as a new service (SSLFingerprintService) that reads all fingerprints from the chain, keeps them in mapping and subscribes to update events in order to update the mapping. The service is passed into the DataAggregator and ultimately each ExchangeAdaptor, there it's used to get the fingerprint in lieu of the static attribute.
Failure modes:
Other changes
N/A
Tested
Related issues
90% of on-call requests.
Backwards compatibility
Nope.