Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging and csv export #3
base: main
Are you sure you want to change the base?
Packaging and csv export #3
Changes from 1 commit
4231cfd
20b7691
bd95e37
d85048e
819595e
b2b4380
b3908ba
1a85536
48cc58b
875a884
8f4e0c7
3b33b78
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't foget about me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Wait shdn't the email be [email protected] and [email protected]?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aliases to full names will also work. But you're right, let's do short usernames only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add classifiers:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Quick query were these stuff something I needed to know before hand. If so where can I find these info?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a) You're missing a comma in the list, between "License" and "Programming Language" classifiers.
b) The list of cannonical classifiers are avaiable at https://pypi.org/classifiers/ this is more a legacy thing and not very important as it has fallen out of use, still a nice thing to do properly.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could each one of the writes (barcodes, features, and annotations) be an individual function. If so, should they be inside Cloupe class?
Have a look at https://docs.python.org/3.9/library/csv.html for writing CSVs with quoting and all that fun.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had been trying various combination of csv writter with the data that we have. I was finding it difficult to dump out the csv properly even when i was using the quoting and quotechar features along with the delimiter. I was thinking if i cud stick without using csv module. Let me know ur thoughts.
Regarding moving the writes as methods. My query would be do i remove the main function entirely and the cloupe.py will remain a class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code ONLY works if there are two celltracks.
What if there are none? What if there's only one? What if there are 99?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also fixed to only support 2 celltracks.
Should be dynamic based on the number of items in
cloupe.celltracks
.re.sub(r"[()' ]", "", str(pair))
is very odd